fix: Make input_sorted_by_group_key tolerate unrelated single value columns outside the group key prefix #171
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…olumns outside the group key prefix
srh
force-pushed
the
fix-input_sorted_by_group_key
branch
from
1d39e45 to
a970b91
Compare
waralexrom
approved these changes
Oct 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a bugfix in input_sorted_by_group_key. Currently, when considering whether to replace hash aggregation with inplace aggregation, it is the case that if there are single value columns in the sort key that aren't part of the prefix of the sort key that the group key matches, we will fail to use Inplace aggregation.
This also implements a basic output_hints() implementation for SortExec, but (while generally useful) that is for the sake of the test that was written.